-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using commandline options AND/OR config file when running start.py #14
Comments
Per issue #27, reminding myself to add options for logging. |
Options for logging added (including basic checking/exception handling) and the branch P.S.: Sorry I should not have merged it into |
Tested, works well. The only thing that is not clear to me is is the priority between command line arguments and config files item. For the moment it seems that config file has precedence over command line arguments. The other way round would feel more natural to me (I would think the In any way, I think this should be mentionned in the documentation ( |
Thanks so much for testing. Yes, the functions implemented in this issue should be documented, and I will do so with priority, since I know it is easy to forget things quickly if you don't document well. As for prioritisation of configuration file versus command line options, I've been thinking about this for the past few days. Most of my experience with command line programs tells me that a user-supplied configuration file will take precedence over any other options. I mean, if the user supplied a configuration file, then presumably that file contains what the user wants. However, I think your suggestion for "the What do you think? |
I am not sure this addresses the point I was trying to make. I just thought that since the config file contains more info than you could reasonably type in a command line (especially if we accept my suggestions in |
Per our discussion on 2020-07-17, the following order of precedence is suggested (based on what seems to be the industry standard): hard-coded defaults < environment variables < user-supplied configuration file < command line arguments/options Where items on the right would override options on the left. |
Right now, our
start.py
needs both commandline options and a.config
file to run. Let's update it so that it is more flexible wherestart.py
can get everything it needs from commandline options, an arbitrarily named configuration file at any location, or a combination of both. In the end, the configuration file would be optional but useful.Also remember to define what happens by default if no options and configuration file are provided.
I suspect this is not the highest priority item right now, but I'm putting this issue here so I will remember to do it someday...
The text was updated successfully, but these errors were encountered: