Allow DUNE modules to locate the dune.module files during CMake run. #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blattms
force-pushed
the
allow-dune-to-find-dune.module
branch
2 times, most recently
from
322cfbd
to
6d03c27
Compare
|
Tested with a play dune module (created by duneproject) depending on opm-grid with installed and uninstalled opm-grid. |
For this we need to set <dune-module>_PREFIX either to where the module is installed to or the source directory for a build with uninstalled modules.
blattms
force-pushed
the
allow-dune-to-find-dune.module
branch
from
6d03c27
to
c6536c0
Compare
|
Rebased and testes with patched dumux version. See OPM/opm-grid#327 |
|
jenkins build this please |
akva2
pushed a commit
to akva2/opm-common
that referenced
this pull request
Jun 10, 2022
Dynamically sized evaluations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this we need to set _PREFIX to some ominous value (at least for installed versions).
I have no idea what I was thinking when implementing and naming it like this in DUNE.The name is actually correct, I just did not see it. _PREFIX either set to where the module is installed to or the source directory for a build with uninstalled modules.This is an
untestedshot to resolve the problem described in #300.