HAVE_OPM_GRID is set to 0 although opm-grid is found

[berndflemisch]

Steps to reproduce this, at least for me:

mkdir TestOpmGrid; cd TestOpmGrid

git clone -b 2018.04 https://github.com/Statoil/libecl.git
mkdir libecl/build; cd libecl/build; cmake ..; make -j7; cd ../..

for MOD in common geometry grid localfunctions istl; do 
git clone -b releases/2.6 https://gitlab.dune-project.org/core/dune-$MOD.git;
done
git clone -b feature/support-cpgrid https://git.iws.uni-stuttgart.de/dumux-repositories/dumux.git

git clone -b release/2018.04 https://github.com/OPM/opm-common.git
git clone -b release/2018.04 https://github.com/OPM/opm-grid.git
cd opm-grid; patch -p1 <../dumux/patches/opm-grid-2018.04.patch; cd ..

export ecl_DIR=$PWD/libecl/build
CMAKE_FLAGS="-Decl_DIR=$ecl_DIR" ./dune-common/bin/dunecontrol all

grep 'opm' dumux/build-cmake/CMakeCache.txt
grep 'HAVE_OPM' dumux/build-cmake/config.h

This gives me

bernd@aladdin:/temp2/bernd/TestOpmGrid> grep 'opm' dumux/build-cmake/CMakeCache.txt
CMAKE_MODULE_PATH:UNINITIALIZED=/temp2/bernd/TestOpmGrid/opm-common/cmake/Modules
opm-common_DIR:UNINITIALIZED=/temp2/bernd/TestOpmGrid/opm-common/build-cmake
opm-grid_DIR:UNINITIALIZED=/temp2/bernd/TestOpmGrid/opm-grid/build-cmake
//Details about finding opm-common
FIND_PACKAGE_MESSAGE_DETAILS_opm-common:INTERNAL=[/temp2/bernd/TestOpmGrid/opm-common/build-cmake/lib/libopmcommon.a][v()]
bernd@aladdin:/temp2/bernd/TestOpmGrid> grep 'HAVE_OPM' dumux/build-cmake/config.h
#define HAVE_OPM_GRID 0

[blattms]

Thanks. Will try to replicate.

[akva2]

i can reproduce, and i can fix, though part of it is a bug and/or expectation violation in/for dunecontrol.

first, you have to pass -DUSE_MPI=1 in CMAKE_FLAGS. dune enables MPI unconditionally if found, in opm it is conditional and off by default. we get out of sync for the HAVE_MPI variable, and consequently opm-grid is not allowed to be used.

secondly, dc and/or dune build system bugs out for suggests. moving opm stuff to requires, it will work, but in that case i have to manually give opm-common_PREFIX and opm-grid_PREFIX for dc to find the dune.module files. i do not care to debug this tbh.

[blattms]

Well, the _PREFIX thing sound familiar, OPM/opm-common#302. IMHO this is rather a non-satisfied prerequisite of the DUNE buildsystem.

[blattms]

Shall I update that PR?

[akva2]

which is why i tried to cover my a** in my first sentence :)

[akva2]

and yes, it's obviously a requirement and very non-intrusive. update, test, will merge.

[berndflemisch]

With OPM/opm-common#302, it works. Thank you! Is it possible that you cherry-pick this to release/2018.04?

[blattms]

Fixed with merge of OPM/opm-common#302