Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local tests errors without build failures #60

Closed
renan-souza opened this issue Oct 29, 2022 · 4 comments
Closed

Local tests errors without build failures #60

renan-souza opened this issue Oct 29, 2022 · 4 comments
Labels
Branch Goal: Documentation Improvements or additions to documentation Priority: Low

Comments

@renan-souza
Copy link
Collaborator

renan-souza commented Oct 29, 2022

The code works for the imagemagick example and there is no build failure in the CI/CD pipeline, but I get the errors below when I run:

$ python -m pytest -m gitlab_runner -sv
============================================================================================================== short test summary info ==============================================================================================================
FAILED tests/test_plugin_git.py::test_git_processCommitAndDownload - TypeError: can only concatenate str (not "NoneType") to str
FAILED tests/test_plugins.py::test_rsync_plugin_check - assert False
FAILED tests/test_plugins.py::test_rsync_plugin_run - TypeError: expected str, bytes or os.PathLike object, not NoneType
FAILED tests/test_queue_factory.py::test_factory_nats - AttributeError: 'NoneType' object has no attribute 'debug'
FAILED tests/test_queue_nats.py::test_queue_nats_connect_close - AttributeError: 'NoneType' object has no attribute 'debug'
FAILED tests/test_queue_nats.py::test_queue_nats_subscribe - AttributeError: 'NoneType' object has no attribute 'debug'
FAILED tests/test_queue_nats.py::test_queue_nats_send_subscribe_nextMsg - AttributeError: 'NoneType' object has no attribute 'debug'
==================================================================================================== 7 failed, 5 passed, 36 deselected in 3.83s =============================================================================

Ps: The unit tests are all green or deselected: python -m pytest -m unit -sv

@JoshuaSBrown JoshuaSBrown added Priority: Low Branch Goal: Documentation Improvements or additions to documentation labels Nov 10, 2022
@JoshuaSBrown
Copy link
Collaborator

Are you running these tests locally? If so the reason for this is because the gitlab_runner tests are using env variables defined in the CI env. A solution to this would be:

  • Better documentation
  • Printed warnings indicating that the env variables are not defined

@JoshuaSBrown
Copy link
Collaborator

@renan-souza do you know if this is still a problem?

@renan-souza
Copy link
Collaborator Author

It's a bit old, still using nats. I'll test it again once we finish the merges and test the CI/CDs, to see if this is still happening.

@JoshuaSBrown
Copy link
Collaborator

These tests should now work in our docker compose file so I'm going to close this, the only tests that will not work are the ones with the globus tags for obvious reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch Goal: Documentation Improvements or additions to documentation Priority: Low
Projects
None yet
Development

No branches or pull requests

2 participants