-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a modern pyproject.toml package structure #164
Conversation
Someone needs to pull down this branch, create a new Python environment, install the package into that environment, make sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without understanding fully what ruff does, I moreso reviewed code cleanliness and that the libraries included were necessary/complete. It does pass those checks, I figure we can merge and test in main.
Just saw this comment. Will do! |
To run the ruff linter/style checks use |
I updated the contributing guidelines to account for the changes made in this pull request. |
@tskluzac Have you had a chance to run the tests and examples in this branch? |
Confirmed! |
This adopts a modern
pyproject.toml
project structure for developing a Python package. Thesetup.py
,setup.cfg
, andMANIFEST.in
files are no longer needed and have been removed. The zambeze package itself now resides in thesrc
directory. All linting and formatting is now done with ruff instead of flake8 and black. The GitHub Actions workflows are also updated to account for these changes. Closes #159.