-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 141 -- fix 'no agent available' user view #166
Conversation
The |
Added docstring to dispatch. Removed |
@wigging please take a look when you get the chance (I forgot to tag you on Friday) |
It looks like you used the Google style for the docstrings. I thought we decided to use the NumPy style? I also suggested the NumPy style in the CONTRIBUTING.md document. So which style should we use? |
You also need to rebase this branch so it's up-to-date with the main branch. |
@wigging I believe this is proper numpy style now (per their docs that you linked in the contributing doc). That's what I get for asking AI for helping in the docstring conversions... |
Indentation is screwed up. """Initializes a Campaign instance.
Parameters
----------
name : str
The name of the campaign.
activities : str, optional
List of science activities for processing by Zambeze.
logger : logging.Logger, optional
Logger object to flush stderr and stdout
force_login : bool
Boolean whether to force a Globus Auth flow.
""" Should be like this: """Initializes a Campaign instance.
Parameters
----------
name : str
The name of the campaign.
activities : str, optional
List of science activities for processing by Zambeze.
logger : logging.Logger, optional
Logger object to flush stderr and stdout
force_login : bool
Boolean whether to force a Globus Auth flow.
""" Same for the other docstrings. Also, All of this can be checked by the linter. But if we enable it in GitHub Actions then most of the Python files would fail because the docstrings are a mess in this project. |
When a local agent is unavailable to relay messages from the client to Zambeze, the user experience should be 'informative and helpful'. This branch is a first attempt at improving that user workflow.
Closes #141