Fixed problem with image magick example not working #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renan-souza
approved these changes
Oct 26, 2022
To make it work with docker compose, I had to enable custom hostnames and ports for nats through environment vars. For this, I created a conf.py file in zambeze to centralize configuration code, such as pulling environment variables. #55
Attempt to fix GitHub action
- Using HOST env var for zmq, and created a ZMQ_PORT var. - Improved README.md for the container execution to provide the steps to run the simple example and expected results. - Made few other code improvements based on @JoshuaSBrown's feedback on this PR: #56 Issue: #55
Adding Dockerfile and docker compose files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image magick was failing because, when a timeout was being thrown by the nats nextMsg command the catch statement was exiting. Was fixed in this issue, by abstracting away the nats specific error and using a generic timeout exception that is caught with out exiting.