Storing in activity table #64
Conversation
- Enabling autoupdate in the installed lib while developing through `pip install -e .` in the Dockerfile - Getting the dependencies from the requirements.txt in setup.py - Using the env var from config.py for the ZMQ port in settings.py - Improving the compose.yml to get logs and wait.
#61 - Enabling saving and updating actitivites in SQLite - Adding the schema (DDL) - Updating requirements.txt to use SQLAlchemy - Creating the code structure for a Data Access Object (DAO) pattern - Adding volumes to the docker compose to persist the saved data in the database - Each agent creates a local database (if there's any yet) in settings.py and stores the activity data in the agent.py - Adding unit tests for these features
renan-souza
requested review from
wilkinson,
JoshuaSBrown,
rafaelfsilva and
tskluzac
There was a problem hiding this comment.
This commit addresses the feedback received by Joshua and Rafael. 8eb2c82
There was a problem hiding this comment.
This commit addresses Joshua's and Rafael's feedback 8eb2c82
|
|
||
| @classmethod | ||
| @property | ||
| @abstractmethod | ||
| def ENTITY_NAME(cls) -> str: | ||
| raise NotImplementedError() |
There was a problem hiding this comment.
Is this what you meant about constants? This is essentially a constant member of the class right?
There was a problem hiding this comment.
We should add something in the CONTRIBUTING.md page about what is expected for constants.
There was a problem hiding this comment.
What does passing in (cls) as the parameter do?
There was a problem hiding this comment.
What does passing in (cls) as the parameter do?
This is the "self" argument but for a class-level method. Since this is supposed to be a class-level (as opposed to instance-level) constant, I believe cls is right.
#61