Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script#save doesn't preserve cluster options #2797

Closed
Tracked by #3394
johrstrom opened this issue May 4, 2023 · 1 comment
Closed
Tracked by #3394

script#save doesn't preserve cluster options #2797

johrstrom opened this issue May 4, 2023 · 1 comment
Milestone

Comments

@johrstrom
Copy link
Contributor

johrstrom commented May 4, 2023

I have to disable this here because there's a bug after you press save here. When a script is created from scratch, the cluster options are correctly serialized. Though through the update path - the options are not preserved. Easiest thing to do is just to disable this test while we fix that bug. I'll be filing the ticket now.

Originally posted by @johrstrom in #2796 (comment)

expected behavior:

  • create a script
  • go to script#edit and you'll see the cluster options are there
  • save the script by pressing the save button
  • go back to edit the same script and the options should be preserved

actual behavior:

  • create a script
  • go to script#edit and you'll see the cluster options are there
  • save the script by pressing the save button
  • go back to edit the same script and cluster is now a text field (the default) instead of a select menu. The cluster options where not preserved (written to yaml) when we saved in the third step here.

┆Issue is synchronized with this Asana task by Unito

@osc-bot osc-bot added this to the Backlog milestone May 4, 2023
@johrstrom johrstrom mentioned this issue May 4, 2023
45 tasks
@johrstrom johrstrom mentioned this issue Mar 1, 2024
53 tasks
@johrstrom johrstrom modified the milestones: Backlog, 4.0 Mar 12, 2024
@johrstrom
Copy link
Contributor Author

I can no longer replicate this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants