redirect to HTTP_HOST to support aliases #3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
commented
Apr 10, 2024
| RewriteRule ^(.*) <%= @ssl ? "https" : "http" %>://<%= @proxy_server %>:<%= @port %>$1 [R=301,NE,L] | ||
| RewriteRule ^(.*) <%= @ssl ? "https" : "http" %>://%{HTTP_HOST}:<%= @port %>$1 [R=301,NE,L] |
There was a problem hiding this comment.
I think this change will work to fix #3442 so that any http -> https redirects will respond to the various server aliases we have. I should actually hop on dev to confirm this.
There was a problem hiding this comment.
I can confirm this works in dev, but could still use a 2nd pair of eyes.
There was a problem hiding this comment.
This looks correct. I think this will even work with Proxies since HTTP_HOST would be the address used to access OnDemand.
treydock
approved these changes
Apr 11, 2024
johrstrom
added a commit
that referenced
this pull request
May 10, 2024
redirect to http requests to HTTP_HOST to support aliases.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redirect to HTTP_HOST to support aliases. Tests will fail for a bit while I update the fixtures, but I want to get a spot check on it before I proceed.
This should fix #3442 - or at least I'm hoping to.