Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement wink2 inverse by generic inversion of forward method #2243

Merged
merged 1 commit into from
May 29, 2020
Merged

Implement wink2 inverse by generic inversion of forward method #2243

merged 1 commit into from
May 29, 2020

Conversation

rouault
Copy link
Member

@rouault rouault commented May 26, 2020 •
edited
Loading

  • Move the generic method initiated from adams_ws2 to a
    pj_generic_inverse_2d() method
  • Use it in adams_ws2
  • Use it in wink2

Fixes qgis/QGIS#35512

@rouault rouault added this to the 7.1.0 milestone May 26, 2020
@rouault rouault mentioned this pull request May 26, 2020
Closed
kbevers
kbevers approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@kbevers kbevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor detail regarding the name of the generic inverse function otherwise this looks good to me. I am happy to see that it works for more than just one projection and I am hopefull that we can extend it to all projections without and inverse at some point.

src/generic_inverse.cpp Outdated Show resolved Hide resolved
@rouault
Implement wink2 inverse by generic inversion of forward method
48b3bd9 
- Move the generic method initiated from adams_ws2 to a
  pj_generic_inverse_2d() method
- Use it in adams_ws2
- Use it in wink2

Fixes qgis/QGIS#35512
@rouault rouault merged commit e9a5add into OSGeo:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbevers kbevers kbevers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

Problem reprojecting rasters in 54019 and 54042 CRSs
2 participants
@rouault @kbevers