-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whole code-base reformatting #3590
Conversation
rouault
commented
Jan 23, 2023
- Add a .pre-commit-config.yaml pre-commit configuration file
- Doc: add a dev_practices.rst page
- Whole code base reformatting
- Add .git-blame-ignore-revs
Doc how to setup pre-commit hook at https://github.com/rouault/PROJ/blob/reformat_whole/docs/source/development/dev_practices.rst |
2cfb811
to
4b8b3ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand the meaning of this item correctly, I think the commit some years back, where you renamed all .c files to .cpp should probably also be ignored? (there may be others as well, which I have lost track of?)
4b8b3ca
to
2356d9a
Compare
I don't believe this is necessary as git is already smart enough to figure out file renames. |
I think you're right: "git blame" appears to work fine - it's just the "contributors"-banner dispayed by Github over each file that only includes people contributing after the renaming. Perhaps more of a Github UI/UX bug-let... |
I had some difficulties installing clang-format-15 in my Ubuntu 22.04 (things are too old or too new)
from http://security.ubuntu.com/ubuntu/pool/universe/l/llvm-toolchain-15/ |
unless you want to manually run reformat_cpp.sh, you don't need to do that. Just follow instructions at https://github.com/rouault/PROJ/blob/reformat_whole/docs/source/development/dev_practices.rst#commit-hooks |