Implement thread-safe creation of proj mutex (fixes #954) #958
Conversation
rouault
force-pushed
the
safe_creation_of_pj_lock
branch
from
bfd3bbd
to
9ee9e7a
Compare
There was a problem hiding this comment.
Thanks for taking care of this. I haven't got enough insight to comment on the implementation but I am wondering if it is possible to create a simple test so we can avoid the original problem in the future? Or is it one of those multithreading problems that only appears in big and complicated settings?
| static pthread_once_t sOnceKey = PTHREAD_ONCE_INIT; | ||
| if( pthread_once(&sOnceKey, pj_create_lock) != 0 ) | ||
| { | ||
| fprintf(stderr, "pthread_once() failed in pj_acquire_lock().\n"); |
There was a problem hiding this comment.
Please use either proj_log_error or proj_log_debug, depending on which you think suits the purpose best.
There was a problem hiding this comment.
proj_log_error() and proj_log_debug() require a PJ* object which we don't have here
There was a problem hiding this comment.
and this error is not supposed to happen in practice. This is mostly so to have a hint of what went wrong in case something (really) bad happen
There was a problem hiding this comment.
PJ* object which we don't have here
Right, I totally missed that.
rouault
force-pushed
the
safe_creation_of_pj_lock
branch
from
e9c50ee
to
565cced
Compare
src/multistresstest.c should already test this. It is extremly difficult to test that there is no race, by definition of races... |
Yeah, that's what I figured. Just wanted to check if you had an idea to improve the multithreading test. |
No description provided.