GetFID incorrect after sorting layer

[jontwo]

Expected behavior and actual behavior.

When a layer is sorted using ExecuteSQL with ORDER BY, the FIDs in the layer are changed such GetFeature returns the wrong feature when using an fid obtained from GetFID.

Steps to reproduce the problem.

See this gist.

In a nutshell:

• add some differently sized features to a layer
• sorted_lyr = ds.ExecuteSQL(f"SELECT * FROM lname ORDER BY OGR_GEOM_AREA ASC")
• make a list of FIDs by iterating the layer and calling GetFID
• for each fid in the list, call GetFeature and check the fid (and area) of the returned feature

Operating system

Rocky Linux release 8.6 (Green Obsidian)

GDAL version and provenance

GDAL 3.4.1 on Python 3.8.12