Build issue with system sqlite3 on Mac

[rouault]

Reported in https://lists.osgeo.org/pipermail/gdal-dev/2022-July/055995.html , building on MacOS with system sqlite3 fails because some symbols are missing

==========
[ 82%] Building CXX object ogr/ogrsf_frmts/sqlite/CMakeFiles/ogr_SQLite.dir/ogrsqlitedatasource.cpp.o
/Users/nsands/Documents/Development/3rdParty/GDAL3/gdal-3.5.0/ogr/ogrsf_frmts/sqlite/ogrsqlitedatasource.cpp:733:21: error: use of undeclared identifier 'sqlite3_enable_load_extension'
                if( sqlite3_enable_load_extension(hDB, 1) == SQLITE_OK )
                    ^
/Users/nsands/Documents/Development/3rdParty/GDAL3/gdal-3.5.0/ogr/ogrsf_frmts/sqlite/ogrsqlitedatasource.cpp:746:21: error: use of undeclared identifier 'sqlite3_load_extension'
                if( sqlite3_load_extension(hDB, aosExtensions[i], nullptr, &pszErrMsg) != SQLITE_OK )
                    ^
2 errors generated.
make[2]: *** [ogr/ogrsf_frmts/sqlite/CMakeFiles/ogr_SQLite.dir/ogrsqlitedatasource.cpp.o] Error 1
make[1]: *** [ogr/ogrsf_frmts/sqlite/CMakeFiles/ogr_SQLite.dir/all] Error 2
make: *** [all] Error 2

Googling around, this is a known issue for other projects too, e.g https://bugs.python.org/issue44997

[forestgnome]

I would rather recommend in
ogr/ogrsf_frmts/sqlite/CMakeLists.txt:
line 31:
option(OGR_SQLITE_ALLOW_LOAD_EXTENSIONS "Whether SQLite extension loading is enabled through the OGR_SQLITE_LOAD_EXTENSIONS configuration option" OFF)

to disable code side loading, even as default for all platforms, or are there any plugin dependencies (??). Sooner or later this option could be misused (outside of the GDAL visibility control), as there is no sandbox-security mechanism.

[rouault]

to disable code side loading

this is not really different from the GDAL pluging loading mechanism that is enabled by default (controlled by CMake variable GDAL_AUTOLOAD_PLUGINS), so I don't see to turn sqlite extension loading off by default, if it is available.

[forestgnome]

yes, you are right with GDAL_AUTOLOAD_PLUGINS.