Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXF: add a DXF_CLOSED_LINE_AS_POLYGON=YES/NO configuration option #10261

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

rouault
Copy link
Member

@rouault rouault commented Jun 21, 2024

to control whether closed POLYLINE/LWPOLYLINE should be exposed as a polygon. Defaults to NO to match current behavior.

Fixes #10153

Also available in DWF driver as DWG_CLOSED_LINE_AS_POLYGON=YES/NO

Also, for DXF, expose existing reader configuration options as open options: INLINE_BLOCKS, MERGE_BLOCK_GEOMETRIES, TRANSLATE_ESCAPE_SEQUENCES, INCLUDE_RAW_CODE_VALUES, 3D_EXTENSIBLE_MODE, CLOSED_LINE_AS_POLYGON, HATCH_TOLERANCE ENCODING

CC @atlight It was not obvious to me what the default of the CLOSED_LINE_AS_POLYGON should be. I see some software like KLayout have even more complicated heuristics/settigs for that policy. See "Polygon formation and LINE/POLYLINE interpretation" at https://www.klayout.de/dxf_format.html

to control whether closed POLYLINE/LWPOLYLINE should be exposed as a
polygon. Defaults to NO to match current behavior.

Fixes OSGeo#10153

Also available in DWF driver as DWG_CLOSED_LINE_AS_POLYGON=YES/NO

Also, for DXF, expose existing reader configuration options as open options:
INLINE_BLOCKS, MERGE_BLOCK_GEOMETRIES, TRANSLATE_ESCAPE_SEQUENCES,
INCLUDE_RAW_CODE_VALUES, 3D_EXTENSIBLE_MODE, CLOSED_LINE_AS_POLYGON,
HATCH_TOLERANCE ENCODING
@rouault rouault force-pushed the DXF_CLOSED_LINE_AS_POLYGON branch from a76980b to 852fc9a Compare June 21, 2024 12:48
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 69.244% (-0.002%) from 69.246%
when pulling 852fc9a on rouault:DXF_CLOSED_LINE_AS_POLYGON
into 082d0e7 on OSGeo:master.

@rouault rouault merged commit b30405f into OSGeo:master Jul 6, 2024
35 checks passed
@hanfangyu
Copy link

hanfangyu commented Sep 3, 2024

@rouault I encountered the same problem and needed a 3.10 java jar package to solve it. How can I get it? I am looking forward to your reply. Thank you.

@rouault
Copy link
Member Author

rouault commented Sep 3, 2024

I encountered the same problem and needed a 3.10 java jar package to solve it.

build master from source. Cf https://gdal.org/en/latest/development/building_from_source.html#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polygon in dxf, after ogr2ogr, got lingstring in geojson
3 participants