gdal2tiles.py: Added support for XYZ tiles (OSM Slippy Map) #2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new --xyz option to generate tiles in the OSM Slippy Map standard ( https://wiki.openstreetmap.org/wiki/Slippy_Map ) where the Y coordinate is flipped. Fixed incorrect indentation in a few places.
|
Thanks, we would also need documentation of the new option in gdal/doc/source/programs/gdal2tiles.rst with a |
|
done |
|
not sure why https://travis-ci.com/github/OSGeo/gdal/jobs/308288415 is failing, it doesn't seem related to this change? |
yes, flake. I've restarted the job |
quipo
added a commit
to quipo/gdal
that referenced
this pull request
Mar 30, 2020
…input This PR fixes two issues: * XYZ tiles were not generated for all zoom levels when a zoom range is specified (e.g. `--zoom=10-12`). I forgot to include this fix in my previous PR (PR OSGeo#2359). Only tiles for the highest zoom level (12) were generated. * When an input .tif image is provided without specifying a `--s_srs` cli parameter, and the image itself is not georeferenced (i.e. it's missing the embedded SRS metadata), the input validation fails, but the program doesn't exit correctly, but hangs instead, as there's still an open pipe (instantiated within multiprocessing.Pool). Given `worker_tile_details()` is a synchronous call that needs to be executed once on the input file, before calling `create_base_tile()`, and cannot be parallelised, there is no need for it to be invoked from within the Pool. This way, if the input validation within `worker_tile_details()` fails, there is no open pipe and the parent process can terminate correctly, reporting the failure with sys.exit(2). I added test cases for both issues.
rouault
pushed a commit
that referenced
this pull request
Mar 31, 2020
… input (#2362) This PR fixes two issues: * XYZ tiles were not generated for all zoom levels when a zoom range is specified (e.g. `--zoom=10-12`). I forgot to include this fix in my previous PR (PR #2359). Only tiles for the highest zoom level (12) were generated. * When an input .tif image is provided without specifying a `--s_srs` cli parameter, and the image itself is not georeferenced (i.e. it's missing the embedded SRS metadata), the input validation fails, but the program doesn't exit correctly, but hangs instead, as there's still an open pipe (instantiated within multiprocessing.Pool). Given `worker_tile_details()` is a synchronous call that needs to be executed once on the input file, before calling `create_base_tile()`, and cannot be parallelised, there is no need for it to be invoked from within the Pool. This way, if the input validation within `worker_tile_details()` fails, there is no open pipe and the parent process can terminate correctly, reporting the failure with sys.exit(2). I added test cases for both issues.
|
Hi, I just wanted to thank you both for getting this in. I wrote about it in a short blog post: https://www.azavea.com/blog/2020/06/18/this-month-we-learned-may-2020/ Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new
--xyzoption to generate tiles in the OSM Slippy Map standard where theYcoordinate is flipped.Also fixed incorrect indentation in a few places.
Fixes #2098