return const OGRSpatialReference* for a few methods(fixes #7377) #7381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make OGRCoordinateTransformation::GetSourceCS() and GetTargetCS() return a const OGRSpatialReference* (fixes Make OGRCoordinateTransformation::GetSourceCS/GetTargetCS() return a const OGRSpatialReference* #7377)
to reflect that those objects should be considered immutable.
The downside is that we have internally to
const_cast<OGRSpatialReference*>, in particular in
OGRGeometry::transform() when assigning GetTargetCS() to the geometry,
as assignSpatialReference() needs to increase the reference count.
Make OGRGeometry::getSpatialReference() return a const OGRSpatialReference*
Make OGRGeomFieldDefn::GetSpatialRef() return a const OGRSpatialReference*