Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OGR: Add OGRLayer::GetExtent3D() #8806

Merged
merged 13 commits into from
Nov 30, 2023
Merged

OGR: Add OGRLayer::GetExtent3D() #8806

merged 13 commits into from
Nov 30, 2023

Conversation

elpaso
Copy link
Collaborator

@elpaso elpaso commented Nov 24, 2023 •
edited
Loading

Fix #8570

TODO:

  • fast implementations for drivers that support/allow it (done for ESRI Shapefile only for now)

@coveralls
Copy link
Collaborator

coveralls commented Nov 24, 2023 •
edited
Loading

Coverage Status

coverage: 67.988% (+0.004%) from 67.984%
when pulling fd9f346 on elpaso:getextent3d
into 0573c8a on OSGeo:master.

rouault
rouault reviewed Nov 24, 2023
View reviewed changes
ogr/ogrsf_frmts/ogrsf_frmts.h Outdated Show resolved Hide resolved
ogr/ogrsf_frmts/generic/ogrlayer.cpp Outdated Show resolved Hide resolved
ogr/ogrsf_frmts/generic/ogrlayer.cpp Outdated Show resolved Hide resolved
ogr/ogrsf_frmts/generic/ogrlayer.cpp Outdated Show resolved Hide resolved
rouault
rouault reviewed Nov 28, 2023
View reviewed changes
ogr/ogr_core.h Outdated Show resolved Hide resolved
rouault
rouault reviewed Nov 28, 2023
View reviewed changes
ogr/ogrsf_frmts/shape/ogrshapelayer.cpp Outdated Show resolved Hide resolved
autotest/ogr/ogr_shape.py Outdated Show resolved Hide resolved
@rouault
Copy link
Member

rouault commented Nov 29, 2023

some Doxygen errors: https://github.com/OSGeo/gdal/actions/runs/7029697053/job/19127794968?pr=8806

@rouault
Copy link
Member

rouault commented Nov 30, 2023

@elpaso besides the comment I just pasted regarding defining OLCFastGetExtent3D for the C# bindings, I believe this PR is ready for the scope we discussed, right ?

@elpaso
Copy link
Collaborator Author

elpaso commented Nov 30, 2023

@elpaso besides the comment I just pasted regarding defining OLCFastGetExtent3D for the C# bindings, I believe this PR is ready for the scope we discussed, right ?

Yes, I think so. As a following step I could try to implement more efficient "OCLFast" methods for drivers that support it.

@rouault
Copy link
Member

rouault commented Nov 30, 2023

As a following step I could try to implement more efficient "OCLFast" methods for drivers that support it.

yes, GeoPackage and PostGIS are ones that could be interesting

@rouault rouault added this to the 3.9.0 milestone Nov 30, 2023
@rouault rouault merged commit 8655f56 into OSGeo:master Nov 30, 2023
30 of 31 checks passed
@elpaso elpaso deleted the getextent3d branch November 30, 2023 16:43
@elpaso elpaso mentioned this pull request Dec 4, 2023
Merged
rouault pushed a commit that referenced this pull request Dec 6, 2023
@elpaso
GPKG: add GetExtent3D semi-fast implementation (#8910)
f355cc1 
Followup #8806:
- provide a semi-fast impplementation for GPKG
- use infinity for unknown/unset MinZ and MaxZ instead of NaN
@elpaso elpaso mentioned this pull request Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouault rouault rouault left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.

Add OGRLayer::GetExtent3D()
3 participants
@elpaso @coveralls @rouault