New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Fix or replace i.pr Perl scripts which fail with perlcritic #619
Comments
Hello, I'm new to open source and i'm interested in solving this issue.Could you please help in getting started with this project and guide me through this issue. Thanks |
Welcome @akshatakulkarni25 ! https://grass.osgeo.org/contribute/development/ there esp.
With respect to this ticket, it would be ideal to rewrite the The new scripts you may then submit as a pull request to this repository (for details, see the "How to use git" instructions above. |
Greetings! I recently began exploring this project. If the issue is still open, I would like to contribute to this. I have experience fixing linter issues. My only concern is regarding the age of the issue. The last comment I see is over a year ago. It would be really helpful if I could get the current state of this issue. |
Hi @AnuRage-git As per the addon history this addon hasn't been touched for a while, so you are most welcome to contribute. |
Hello @neteler . I have changed both the files. I do apologise for the delay in response for this small change. The issue was mostly change in function definitions in the new version of Perl. I have made those changes in the files and have initiated a pull request. Do let me know if any other change is required |
Name of the addon
i.pr
Describe the bug
Perl scripts for i.pr in
src/imagery/i.pr/PRLIB/
trigger warnings from the perl linter in Super-Linter.To Reproduce
Run perlcritique or perl linter from Super-Linter.
perlcritic .
Expected behavior
No linter issues from the code and enabled Perl checks in Super-Linter.
Screenshots
perlcritic:
Super-Linter GitHub Action:
Additional context
Super-Linter checks for Perl need to be disabled now.
This can be fixed by rewriting the script in Python.
The text was updated successfully, but these errors were encountered: