Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix or replace csv_dequote.pl Perl script #620

Open
wenzeslaus opened this issue Oct 2, 2021 · 3 comments
Open

[Bug] Fix or replace csv_dequote.pl Perl script #620

wenzeslaus opened this issue Oct 2, 2021 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers Perl Related code is in Perl Python Related code is in Python

Comments

@wenzeslaus
Copy link
Member

wenzeslaus commented Oct 2, 2021 •
edited

Helper/utility tool/script csv_dequote.pl triggers warnings from the perl linter in Super-Linter.

To Reproduce

Run perlcritique or perl linter from Super-Linter.

perlcritic .

Expected behavior

No linter issues from the code and enabled Perl checks in Super-Linter.

Screenshots

perlcritic:

tools/csv_dequote.pl: Bareword file handle opened at line 49, column 1.  See pages 202,204 of PBP.  (Severity: 5)
tools/csv_dequote.pl: Bareword file handle opened at line 50, column 1.  See pages 202,204 of PBP.  (Severity: 5)

Super-Linter GitHub Action:

2021-10-02T07:49:28.2513009Z File:[./tools/csv_dequote.pl]
2021-10-02T07:49:28.2556332Z ERROR! Found errors in [perl] linter!
2021-10-02T07:49:28.2559533Z ERROR:[Can't locate Text/CSV.pm in @INC (you may need to install the Text::CSV module) (@INC contains: /usr/local/lib/perl5/site_perl /usr/local/share/perl5/site_perl /usr/lib/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib/perl5/core_perl /usr/share/perl5/core_perl) at ./tools/csv_dequote.pl line 23.
2021-10-02T07:49:28.2561103Z BEGIN failed--compilation aborted at ./tools/csv_dequote.pl line 23.]

Additional context

Super-Linter checks for Perl need to be disabled now.

This can be fixed by rewriting the script in Python.
@wenzeslaus wenzeslaus added the bug Something isn't working label Oct 2, 2021
@wenzeslaus wenzeslaus changed the title [Bug] csv_dequote.pl Perl script fails with perlcritic and Super-Linter [Bug] Fix or replace csv_dequote.pl Perl script Oct 2, 2021
wenzeslaus added a commit to wenzeslaus/grass-addons that referenced this issue Oct 7, 2021
@wenzeslaus
Do not test for Perl (waits for OSGeo#619 and OSGeo#620)
5631de4
wenzeslaus added a commit that referenced this issue Oct 7, 2021
@wenzeslaus
CI: Add Super-Linter (#618)
87771d7 
* Add Super-Linter job from core.
* Skip Perl checks (more config needed or waits for #619 and #620).
* Skip XML checks (more config needed or waits for wx.metadata, #625).
@wenzeslaus wenzeslaus added Perl Related code is in Perl Python Related code is in Python good first issue Good for newcomers labels Oct 7, 2021
@sumit-158
Copy link

I am new to open source ,but I wanna work on this issue I also need guidance

@wenzeslaus
Copy link
Member Author

Welcome to the open source world!

Unless you happen to know Perl, it might be most beneficial for you and for the project to rewrite it to Python.

Here are some tips: Read the contributing file. Read what the script utils/csv_dequote.pl is doing. Search online for "reading and writing CSV with Python".

IvanMarchesini pushed a commit to IvanMarchesini/grass-addons that referenced this issue Feb 24, 2022
@wenzeslaus @IvanMarchesini
CI: Add Super-Linter (OSGeo#618)
5062ecc 
* Add Super-Linter job from core.
* Skip Perl checks (more config needed or waits for OSGeo#619 and OSGeo#620).
* Skip XML checks (more config needed or waits for wx.metadata, OSGeo#625).
@AnuRage-git
Copy link
Contributor

Hello again @wenzeslaus. I would like to start with the good first issues of grass-addons first. I would like to work on this issue next if it's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers Perl Related code is in Perl Python Related code is in Python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wenzeslaus @sumit-158 @AnuRage-git