-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] url mismatch downloading addons for 7.8 dev release on Windows #1583
Comments
I have also recently noticed that we have this inconsistency in 7.8.dev/7.8dev/7.8.6dev. grass --config version for releasebranch_7_8 reports 7.8.6dev, but elsewhere we use 7.8 with some dev after it. It is not a surprise that Python has a PEP for version numbers (PEP 440) as well a package (versioneer) which covers non-released versions too (similarly to |
Yes, we are rather inconsistent here, compare: https://github.com/OSGeo/grass/blob/releasebranch_7_8/include/VERSION We should decide this and document it in |
For example, PEP 440 Developmental releases has Given that we create the release from the major-minor branch (and not from a dedicated major-minor-patch/major-minor-micro branch), it makes sense to me that the full version number of the upcoming release is included together with a dev suffix (7.8.6dev, 7.8.6.dev, 7.8.6-dev). This could apply to all release branches. This could be applied even to the main branch where the upcoming release is simply the one which will be eventually branched out including 0 as patch/micro version number (so now it would be 8.2.0dev or 8.1.0dev). Applying this logic to the main branch would remove the odd-even release numbering, i.e., the odd numbers would not have to be reserved for the development version. On the other hand, strictly applying the "odd minor version number is development" logic, there is no need for dev suffix on main because that's what the odd minor version number says already. In any case, zero can be added as patch/micro version number on the main branch to align with the release branches. |
What we currently have:
--> Seems that |
I'd say, |
Is the issue still relevant today? It's grass7.8, so it could be unfixed as the version is out of support (I can't find the exact document that states that decision, as is written for python versions support). |
Great thanks! Another issue closed! As you see I'll be going through existing issues and PRs in the following weeks, and we'll manage to reduce the backlog! |
Thanks a lot for your effort! |
Describe the bug
Trying to install addons with 7.8 developer release from eg.
https://wingrass.fsv.cvut.cz/grass78/x86_64/osgeo4w/
fails.It tries to download from:
https://wingrass.fsv.cvut.cz/grass78/x86_64/addons/grass-7.8.6dev/
but the actual location is:
https://wingrass.fsv.cvut.cz/grass78/x86_64/addons/grass-7.8.dev/
.To Reproduce
g.extension
System description (please complete the following information):
Additional context
This may be addressed by either changing the url on server, or in code in
g.extension.py
.The text was updated successfully, but these errors were encountered: