Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init: Fix missing parameters in gettext.install() #2539

Merged
merged 1 commit into from
Sep 17, 2022
Merged

init: Fix missing parameters in gettext.install() #2539

merged 1 commit into from
Sep 17, 2022

Conversation

pesekon2
Copy link
Contributor

fix #2507

@pesekon2 pesekon2 added the bug Something isn't working label Aug 27, 2022
@pesekon2 pesekon2 added this to the 8.4.0 milestone Aug 27, 2022
@pesekon2 pesekon2 requested a review from neteler August 27, 2022 09:27
@pesekon2 pesekon2 self-assigned this Aug 27, 2022
@pesekon2 pesekon2 requested a review from hellik August 27, 2022 09:31
@pesekon2
Copy link
Contributor Author

As the codeset= parameter used to affect only l*gettext() functions and they have been removed here, this should fix the issue. Tested with the following configs:

Config 1:

lsb_release -d
Description:	Debian GNU/Linux 10 (buster)

python3 --version
Python 3.11.0rc1

Config 2:

lsb_release -d
Description:	Debian GNU/Linux bookworm/sid

python3 --version
Python 3.10.4

Can somebody test if it doesn't cause any issue on Windows? @hellik?

@wenzeslaus wenzeslaus added this to In progress in OSGeo Community Sprint 2022 via automation Aug 27, 2022
@pesekon2 pesekon2 mentioned this pull request Sep 14, 2022
Closed
@pesekon2 pesekon2 merged commit c726ae1 into OSGeo:main Sep 17, 2022
OSGeo Community Sprint 2022 automation moved this from In progress to Done Sep 17, 2022
@pesekon2 pesekon2 deleted the gettext_fix_missing_parameters branch September 17, 2022 10:05
@neteler
Copy link
Member

neteler commented Dec 22, 2022

Backport was done in 31a672d

@neteler neteler modified the milestones: 8.3.0, 8.2.1 Dec 22, 2022
@wenzeslaus wenzeslaus changed the title grass.py: fix missing parameters in gettext.install() init: Fix missing parameters in gettext.install() Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neteler neteler Awaiting requested review from neteler

@hellik hellik Awaiting requested review from hellik

Assignees

@pesekon2 pesekon2

Labels
bug Something isn't working
Projects
No open projects
OSGeo Community Sprint 2022
Done
Milestone
8.2.1
Development

Successfully merging this pull request may close these issues.

[Bug] Python 3.11gettext: unexpected keyword argument 'codeset'
2 participants
@pesekon2 @neteler