Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle size_t length arguments properly in ClientKit wrapper. #12

Closed
rpavlik opened this issue Feb 20, 2015 · 2 comments
Closed

Handle size_t length arguments properly in ClientKit wrapper. #12

rpavlik opened this issue Feb 20, 2015 · 2 comments

Comments

@rpavlik
Copy link
Member

rpavlik commented Feb 20, 2015

Lines I'm talking about:

The corresponding C methods those invoke are here: https://github.com/OSVR/OSVR-Core/blob/master/inc/osvr/ClientKit/ParametersC.h

Note that those are actually size_t which is platform dependent, and which I think we can assume is the same as uint_ptr_t. size_t is the idiomatic type to use there from a C and C++ perspective, so if reasonable I'd like to leave those signatures alone. However, it poses an issue to the .NET bindings. It looks like there's a way to handle it properly. If it turns out to be unfeasible, we can change those to uint32_t if needed, since that should be a big enough type, but if a solution isn't too hard that's just in the .NET stuff I think that's probably preferred.

Here are the links I've collected related to this issue.

@rpavlik rpavlik modified the milestone: 64-bit Unity Plugin Feb 25, 2015
@rpavlik
Copy link
Member Author

rpavlik commented Mar 31, 2015

OK, this has been done in the new separated-out https://github.com/OSVR/Managed-OSVR repo, so once we port to there, it will just be some build system changes.

@rpavlik
Copy link
Member Author

rpavlik commented Apr 1, 2015

Going to consider this closed, since other issues refer to the build system changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant