Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect_info_ne op v14 geeft {0,0} #687

Closed
poorthuis-w opened this issue Mar 19, 2024 · 4 comments
Closed

connect_info_ne op v14 geeft {0,0} #687

poorthuis-w opened this issue Mar 19, 2024 · 4 comments
Assignees
Labels
bug Something isn't working calculations Producing primary data, functions invalid This doesn't seem right
Milestone

Comments

@poorthuis-w
Copy link

image

@MaartenHilferink
Copy link
Collaborator

MaartenHilferink commented Mar 19, 2024

Reproduced:
Open d:\prj\pbl\vesta50\runs\s3f_d_lt30_70.dms; branch V_LD_v14; SourceDataProjDir=e:\SourceData\SD41_532

Ctrl-D op
/TussenResultaten/R3_2030/GebiedsAllocatie/Lt30_70/impl/BronIterations/I0/ClusterSet/Connections

Geeft in debug-build met v14.14.1 een assertion failure op:
image

image

@MaartenHilferink
Copy link
Collaborator

Bug was waarschijnlijk op 3 mei 2023 geïntroduceerd (versie 9.1.):

v9.0.3...v9.1.0#diff-f4a409dbab65ef45ab39b234adba6ef275f08b2358fc41408f30b4d73991220f

image

@MaartenHilferink
Copy link
Collaborator

image

Ik zal vanmiddag een Prerelease van 14.14.1 maken met daar in deze fix.

@MaartenHilferink MaartenHilferink added this to the v14.14 milestone Mar 19, 2024
@MaartenHilferink
Copy link
Collaborator

MaartenHilferink commented Mar 19, 2024

This issue is fixed in https://github.com/ObjectVision/GeoDMS/releases/tag/v14.14.1

Impact Assessment:
The use of m_CutPoint in GeoDist.h and Connect.cpp indicate that this issue may have affected all results of connect and connect_info variants that should connect points to linestrings with only one point, which typically doesn't happen when connecting building point-locations to streets, but does happen when clustering point sources with connecting pipes.

@MaartenHilferink MaartenHilferink added bug Something isn't working invalid This doesn't seem right calculations Producing primary data, functions labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working calculations Producing primary data, functions invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants