cmd: add init logger in printFlags (#1277)

Inits logging as soon as log flags are parsed in printFlags function.

category: bug
ticket: #1272

app/app.go

@@ -123,9 +123,6 @@ func Run(ctx context.Context, conf Config) (err error) {
 	}()
 
 	_, _ = maxprocs.Set()
-	if err := log.InitLogger(conf.Log); err != nil {
-		return err
-	}
 
 	if err := featureset.Init(ctx, conf.Feature); err != nil {
 		return err

cmd/bootnode.go

@@ -59,6 +59,10 @@ func newBootnodeCmd(runFunc func(context.Context, BootnodeConfig) error) *cobra.
 		Long:  `Starts a discv5 bootnode that charon nodes can use to bootstrap their p2p cluster`,
 		Args:  cobra.NoArgs,
 		RunE: func(cmd *cobra.Command, args []string) error {
+			if err := initLogger(cmd.Flags()); err != nil {
+				return err
+			}
+
 			printFlags(cmd.Context(), cmd.Flags())
 
 			return runFunc(cmd.Context(), config)
@@ -91,10 +95,6 @@ func RunBootnode(ctx context.Context, config BootnodeConfig) error {
 
 	ctx = log.WithTopic(ctx, "bootnode")
 
-	if err := log.InitLogger(config.LogConfig); err != nil {
-		return err
-	}
-
 	version.LogInfo(ctx, "Charon bootnode starting")
 
 	key, err := p2p.LoadPrivKey(config.DataDir)

cmd/cmd.go

@@ -156,3 +156,21 @@ func printFlags(ctx context.Context, flags *pflag.FlagSet) {
 
 	log.Info(ctx, "Parsed config", zStrs...)
 }
+
+// initLogger initialises logger based on provided log config flags.
+func initLogger(flags *pflag.FlagSet) error {
+	logLevel := flags.Lookup("log-level")
+	logFmt := flags.Lookup("log-format")
+
+	if logLevel != nil && logFmt != nil {
+		err := log.InitLogger(log.Config{
+			Level:  logLevel.Value.String(),
+			Format: logFmt.Value.String(),
+		})
+		if err != nil {
+			return err
+		}
+	}
+
+	return nil
+}

cmd/dkg.go

@@ -35,6 +35,10 @@ distributed validator key shares and a final cluster lock configuration. Note th
 this command at the same time.`,
 		Args: cobra.NoArgs,
 		RunE: func(cmd *cobra.Command, args []string) error {
+			if err := initLogger(cmd.Flags()); err != nil {
+				return err
+			}
+
 			printFlags(cmd.Context(), cmd.Flags())
 
 			return runFunc(cmd.Context(), config)

cmd/run.go

@@ -41,6 +41,10 @@ func newRunCmd(runFunc func(context.Context, app.Config) error) *cobra.Command {
 			ctx, cancel := signal.NotifyContext(cmd.Context(), os.Interrupt)
 			defer cancel()
 
+			if err := initLogger(cmd.Flags()); err != nil {
+				return err
+			}
+
 			printFlags(ctx, cmd.Flags())
 
 			return runFunc(ctx, conf)

dkg/dkg.go

@@ -65,10 +65,6 @@ func Run(ctx context.Context, conf Config) (err error) {
 		}
 	}()
 
-	if err := log.InitLogger(conf.Log); err != nil {
-		return err
-	}
-
 	version.LogInfo(ctx, "Charon DKG starting")
 
 	def, err := loadDefinition(ctx, conf)