cmd: add init logger in printFlags #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
approved these changes
Oct 13, 2022
| logLevel := flags.Lookup("log-level") | ||
| logFmt := flags.Lookup("log-format") | ||
|
|
||
| if logLevel != nil && logFmt != nil { |
There was a problem hiding this comment.
best not do two things at once, call this manually before printFlags
dB2510
force-pushed
the
dhruv/initlogger
branch
from
ca6b410
to
325b40a
Compare
Codecov ReportBase: 53.41% // Head: 53.80% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1277 +/- ##
==========================================
+ Coverage 53.41% 53.80% +0.38%
==========================================
Files 139 139
Lines 16356 16457 +101
==========================================
+ Hits 8737 8855 +118
+ Misses 6362 6340 -22
- Partials 1257 1262 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dB2510
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inits logging as soon as log flags are parsed in printFlags function.
category: bug
ticket: #1272