Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log format not applied to all logs #1272

Closed
corverroos opened this issue Oct 12, 2022 · 0 comments · Fixed by #1277
Closed

Log format not applied to all logs #1272

corverroos opened this issue Oct 12, 2022 · 0 comments · Fixed by #1277
Assignees
@dB2510
Labels
bug Something isn't working

Comments

@corverroos
Copy link
Contributor

Problem to be solved

When configuring charon with a non-default logging format, e,g. --log-format=logfmt, some initial logs are in the default format.

This is because we only init the logging format in app.Run, while we log stuff before that in the cmd package.

Proposed solution

Init logging as soon as log flags are parsed.
@corverroos corverroos added the bug Something isn't working label Oct 12, 2022
@dB2510 dB2510 mentioned this issue Oct 13, 2022
Merged
@dB2510 dB2510 self-assigned this Oct 13, 2022
@dB2510 dB2510 linked a pull request Oct 13, 2022 that will close this issue
cmd: add init logger in printFlags #1277
Merged
obol-bulldozer bot pushed a commit that referenced this issue Oct 13, 2022
@dB2510
cmd: add init logger in printFlags (#1277)
bffcbb5 
Inits logging as soon as log flags are parsed in printFlags function.

category: bug
ticket: #1272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd: add init logger in printFlags ObolNetwork/charon
2 participants
@corverroos @dB2510