Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actualSamples is not added when allPages is equal to True in scalardata service #29

Open
kan-fu opened this issue Feb 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@kan-fu
Copy link
Collaborator

kan-fu commented Feb 29, 2024

allPages=True in scalardata services can concatenate data from multiple pages. However the actualSamples is not summed.

Steps to reproduce:

  1. Run the code snippet below. Without "rowLimit", the json should return 60 files.
params = {
    "deviceCode": "BPR-Folger-59",
    "dateFrom": "2019-11-23T00:00:00.000Z",
    "dateTo": "2019-11-23T00:01:00.000Z",
    "rowLimit": 25,
}
data = onc.getDirectByDevice(params, allPages=True)
data["sensorData"]

Expected behavior:

  • actualSamples should be 60.

Actual behavior:

  • actualSamples is 25 (it returns the value from querying the first page)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant