Extended netcdf export format dictionary to unsigned ints #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice addition, but should these types then also be tested in test_particlefile.py? I.e. add them to the line |
|
Thanks @erikvansebille - the AoS mode claims not to support 8- or 16-bit integers in JIT. I don't use the AoS mode so am not familiar with why this would be (there was already an exception in the test for bool types) so I've added all the new particle types with an exception for 8- and 16-bit types for AoT mode w/ JIT. |
erikvansebille
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format dictionary we set up a while ago was missing unsigned integers + 8-bit integers, so I've just added those.