-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Readthedocs #1290
Fix Readthedocs #1290
Conversation
79b33c5
to
1fcd1a8
Compare
Thanks for this PR, @VeckoTheGecko. Your idea to automatically link through readthedocs.io is a good one! I forgot that we had a place for parcels there in the past... One question; does the |
I had the same thought, but unfortunately it has to be in the project root. |
Fixed the following error which resulted in missed documentation. WARNING: autodoc: failed to import module 'plottrajectoriesfile' from module scripts'; the following exception was raised: No module named 'scripts'
73a24dd
to
8dff121
Compare
OK, is this ready to be merged now? |
Good to go! I'm not sure if additional config needs to be done on your end (as the owner for the |
Looks like the official deployment isn't updating. I've updated my fork to master and that deployment is good. It would be good to check the config/builds on RTD. |
I manually triggered the build, so the pages seem to now be updated. I'll have to check how to auto-build (via a hook?) |
Hmm, and I now also see that the left side panel (with the table of content etc) doesn't work at https://parcels.readthedocs.io/en/latest/#. Did you do anything special to get that working on your fork, @VeckoTheGecko? |
Strange. Are there any errors visible in the build logs? I didn't do any additional configuration on my side outside of this PR. I don't have hooks/automation rules, though I do have an integration (which I think was added by default on setup). Perhaps that could be it? |
I haven't changed anything, but the disbar seems to work now. So all good after all. I just also updated the links on oceanparcels.org, to link directly to https://parcels.readthedocs.io/ |
Good point, I now removed all these older versions for which the RTD integration was not working yet |
Fixes #1288
Deployment on my fork is visible here: https://veckoparcels.readthedocs.io/en/patch-rtd/