Warnings as errors fixes #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, merged! |
|
@ahornung Could you please create a patch release for v1.9 with this PR included? I'd love to get the version in Noetic updated :-). |
|
@wxmerkt Done, thanks for the heads up! |
|
Thank you, the release is out - ros/rosdistro#28068 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing some warnings, most are minor ones, except for missing copy constructor for Pose6D which leads to the following message (compiled with -std=c++2a):
warning: implicitly-declared 'octomath::Pose6D::Pose6D(const octomath::Pose6D&)' is deprecated [-Wdeprecated-copy]note: because 'octomath::Pose6D' has user-provided 'octomath::Pose6D& octomath::Pose6D::operator=(const octomath::Pose6D&)'so i've added copy ctor for consistency
notes:
it might make sense to provide move operations along with copy, conditionaly defined if c++ >= 11 is available
i've also added warning as errors flags to compiler flags list - don't know if it's appropriate for this project, so i'm ok to remove it if requested
unused parameters names wrapped with comments - might be removed alternatively, seems like a style choice that should be consistent with the whole project (is it now?)