Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Software Update: Improve logging in case of failing update checks #4332

Closed
foosel opened this issue Dec 7, 2021 · 3 comments
Closed
Labels
done Done but not yet released request Feature request
Milestone

Comments

@foosel
Copy link
Member

foosel commented Dec 7, 2021

Is your feature request related to a problem? Please describe.

As witnessed on the forums here there's currently insufficient logging in case of failures in running update checks, e.g. GitHub release fetching with an outdated PAT. The "available" version simply stays empty without any log message to indicate why.

Describe the solution you'd like

A failing request should at least cause a log entry, not just a silent error. That would allow easier debugging of a failure to check for updates. Better yet would be to log the reason for the error in the frontend, like with rate limiting situations. Something like "Backend request failed, see log" would already be more helpful than the current sitation.

Describe alternatives you've considered

No response

Additional context

https://community.octoprint.org/t/not-being-offered-upgrades/38829

@foosel foosel added the request Feature request label Dec 7, 2021
@foosel foosel added this to the 1.8.0 milestone Dec 7, 2021
@GitIssueBot
Copy link

This issue has been mentioned on OctoPrint Community Forum. There might be relevant details there:

https://community.octoprint.org/t/not-being-offered-upgrades/38829/37

foosel added a commit that referenced this issue Feb 28, 2022
@foosel foosel added the done Done but not yet released label Feb 28, 2022
@foosel
Copy link
Member Author

foosel commented Feb 28, 2022

This will be in 1.8.0

@foosel foosel mentioned this issue Feb 28, 2022
6 tasks
@cp2004
Copy link
Member

cp2004 commented May 17, 2022

1.8.0 has been released 🎉

@cp2004 cp2004 closed this as completed May 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
done Done but not yet released request Feature request
Projects
None yet
Development

No branches or pull requests

3 participants