Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3,
filter()
returns an iterable rather than a list. Whilst this is better for performance, our list is not long and it means we can calllen()
on the list.Tested using reproduction steps in #3814 and verified that language packs can now be installed properly.
Closes #3814
to a large audience (ideally all users of OctoPrint)
made sure your changes don't interfere with current development by
talking it through with the maintainers, e.g. through a
Brainstorming ticket
new feature, or maintenance if it's a bug fix or improvement of
existing functionality for the current stable version (no PRs
against master or anything else please)
(no PRs from your version of master, maintenance or devel please),
e.g. dev/my_new_feature or fix/my_bugfix
no dead code, ideally only one commit - rebase and squash your PR
if necessary!
.less source files, not the .css files (those are generated with
lessc)
have added unit tests
nothing broke
What does this PR do and why is it necessary?
Fixes issue uploading language packs on Python 3. This doesn't appear to be a regression in 1.5.0rc1, and a change introduced by 63723ba that removed a change introduced by 30359f5, both claiming to do the same thing.
How was it tested? How can it be tested by the reviewer?
Follow steps outlined in #3814
Any background context you want to provide?
#3814 and #3802 (comment)
What are the relevant tickets if any?
#3814 and #3802 (comment)
Screenshots (if appropriate)
Further notes
Not sure if this counts as a regression, since it has been an issue since 1.4.0 was released, and only when using Python 3. However, since more and more users are moving to Python 3, or installing by default now (both manual and soon OctoPi) I think this should be included in 1.5.0. But at the end of the day, its not up to me. Change the branch to whatever you think works for this fix 🙂