Check if paused for printer.is_ready #4336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
targets maintenance
foosel
requested changes
Dec 13, 2021
foosel
added
the
needs some work
foosel
requested changes
Dec 13, 2021
foosel
approved these changes
Dec 13, 2021
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why is it necessary?
Checks for paused print in the is_ready method.
How was it tested? How can it be tested by the reviewer?
With the BetterHeaterTimeout plugin, it can be tested by anything that checks the is_ready API while the printer is ready and when it's paused.
Any background context you want to provide?
Found it when using BetterHeaterTimeout plugin
What are the relevant tickets if any?
Screenshots (if appropriate)
Further notes