Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typo in german translation #4550

Closed
wants to merge 1 commit into from
Closed

Conversation

CoReYeDe
Copy link
Contributor

@CoReYeDe CoReYeDe commented Jun 22, 2022

  • Your changes are not possible to do through a plugin and relevant
    to a large audience (ideally all users of OctoPrint)
  • If your changes are large or otherwise disruptive: You have
    made sure your changes don't interfere with current development by
    talking it through with the maintainers, e.g. through a
    Brainstorming ticket
  • Your PR targets OctoPrint's devel branch if it's a completely
    new feature, or maintenance if it's a bug fix or improvement of
    existing functionality for the current stable version (no PRs
    against master or anything else please)
  • Your PR was opened from a custom branch on your repository
    (no PRs from your version of master, maintenance or devel please),
    e.g. dev/my_new_feature or fix/my_bugfix
  • Your PR only contains relevant changes: no unrelated files,
    no dead code, ideally only one commit - rebase and squash your PR
    if necessary!
  • Your changes follow the existing coding style
  • If your changes include style sheets: You have modified the
    .less source files, not the .css files (those are generated with
    lessc)
  • You have tested your changes (please state how!) - ideally you
    have added unit tests
  • You have run the existing unit tests against your changes and
    nothing broke
  • You have added yourself to the AUTHORS.md file :)

What does this PR do and why is it necessary?

How was it tested? How can it be tested by the reviewer?

Any background context you want to provide?

What are the relevant tickets if any?

Screenshots (if appropriate)

Further notes

@github-actions github-actions bot added targets devel The PR targets the devel branch approved Issue has been approved by the bot or manually for further processing labels Jun 22, 2022
@foosel
Copy link
Member

foosel commented Jun 23, 2022

Hey there, thank you for this PR! Since it's not really a "backwards compatibility breaking change" it shouldn't go against devel however but actually against maintenance, see the "Pull requests" section of the Contribution Guidelines, point 4. Could you please cherry-pick your commit against that and force push this PR, or alternatively close this PR and open a new one against maintenance with your changes? That would be lovely! Thank you!

Copy link
Member

@foosel foosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As state above.

@foosel foosel added this to the 1.9.0 milestone Jun 23, 2022
@CoReYeDe
Copy link
Contributor Author

Ok sorry. I reopen this PR for the Maintenance-Branch and read the Guidelines again :)

@CoReYeDe CoReYeDe closed this Jun 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Issue has been approved by the bot or manually for further processing targets devel The PR targets the devel branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants