Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new filament sensor plugin. #231

Merged
merged 1 commit into from
Oct 12, 2018
Merged

Conversation

Red-M
Copy link
Contributor

@Red-M Red-M commented Sep 17, 2018

The other two don't seem to work as the original plugin does not work and the newer one segfaults.
I've fixed this and added functionality from both into one along with my own additions.

@foosel
Copy link
Member

foosel commented Sep 18, 2018

You forgot to adjust the update information within your plugin code, its key is still filamentsensor but should be filamentsensorng :)

@Red-M
Copy link
Contributor Author

Red-M commented Sep 18, 2018

I believe I've update that key and I've pushed a release for that as well.
Thanks for spotting that.

@Red-M
Copy link
Contributor Author

Red-M commented Oct 6, 2018

Did I update the wrong thing?

@kantlivelong kantlivelong merged commit 8351046 into OctoPrint:gh-pages Oct 12, 2018
@kantlivelong
Copy link
Contributor

Hi @Red-M,

We don't get notifications for external projects. I've taken a look and it appears to be good now.

Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants