Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TryGetPartById #714

Merged
merged 5 commits into from
May 12, 2020
Merged

Add TryGetPartById #714

merged 5 commits into from
May 12, 2020

Conversation

lindexi
Copy link
Member

@lindexi lindexi commented May 8, 2020

Fix #712

twsouthwick
twsouthwick requested changes May 11, 2020
View reviewed changes
Copy link
Member

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits, but overall looks good. Can you update the README to include this change?

src/DocumentFormat.OpenXml/Packaging/OpenXmlPartContainer.cs Outdated Show resolved Hide resolved
src/DocumentFormat.OpenXml/Packaging/OpenXmlPartContainer.cs Outdated Show resolved Hide resolved
src/DocumentFormat.OpenXml/Packaging/OpenXmlPartContainer.cs Outdated Show resolved Hide resolved
@lindexi
Copy link
Member Author

lindexi commented May 12, 2020

A couple nits, but overall looks good. Can you update the README to include this change?

Update CHANGELOG ?

@lindexi
Copy link
Member Author

lindexi commented May 12, 2020

@twsouthwick Thank you and I fix it

@lindexi lindexi requested a review from twsouthwick May 12, 2020 01:23
twsouthwick
twsouthwick reviewed May 12, 2020
View reviewed changes
Copy link
Member

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once the build passes I'll merge it in

@twsouthwick twsouthwick merged commit 34aead1 into dotnet:master May 12, 2020
@lindexi lindexi deleted the t/lindexi/WuniwililemCereqallburwhairloke branch May 13, 2020 00:11
@lindexi lindexi mentioned this pull request May 13, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twsouthwick twsouthwick twsouthwick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the TryGetPartById to OpenXmlPartContainer
2 participants
@lindexi @twsouthwick