Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict between Next.js router and Office.js #2327

Open
3 tasks done
lkedmi opened this issue Dec 23, 2021 · 11 comments
Open
3 tasks done

Conflict between Next.js router and Office.js #2327

lkedmi opened this issue Dec 23, 2021 · 11 comments
Assignees
Labels
Area: DevX Issue is related to Developer Experience (DevX) Area: Word Issue related to Word add-ins Needs: author feedback Waiting for author (creator) of Issue to provide more info Status: no recent activity Issue or PR is stale (no recent activity) Status: under investigation Issue is being investigated Type: programming question How-to question that should be posted to Microsoft Q&A

Comments

@lkedmi
Copy link

lkedmi commented Dec 23, 2021

Provide required information needed to triage your issue

I'm using Next.js as the framework for a Word plugin, trying to at least. Next.js has their own router implementation which gets overridden by Office.js.
It's caused by this piece of code:

window.history.pushState = null;

In my case, this piece of code nullify both functions.

Your Environment

  • Platform [PC desktop, Mac, iOS, Office on the web]: Macbook Pro
  • Host [Excel, Word, PowerPoint, etc.]: Word
  • Office version number: 16.56
  • Operating System: OSX Monterey
  • Browser (if using Office on the web): Chrome 96.0.4664.110

Expected behavior

Not override and nullify window.history.pushState when window.next is set.

Current behavior

The Next.js router breaks when loading Office.js

Steps to reproduce

  1. Start a new Next.js project
  2. Configure a simple manifest
  3. Add a link from one page to another
  4. Run the Word plugin
  5. Click the link

Link to live example(s)




Provide additional details




Context

I was hoping to build a Word plugin and base it on Next.js, but due to this behaviour, it doesn't looks like it's possible, which is a shame.

Useful logs

  • Console errors
  • Screenshots
  • Test file (if only happens on a particular file)

Thank you for taking the time to report an issue. Our triage team will respond to you in less than 72 hours. Normally, response time is <10 hours Monday through Friday. We do not triage on weekends.

@ghost ghost added the Needs: triage 🔍 New issue, needs PM on rotation to triage ASAP label Dec 23, 2021
@LuyiH LuyiH added Area: Word Issue related to Word add-ins Type: programming question How-to question that should be posted to Microsoft Q&A and removed Needs: triage 🔍 New issue, needs PM on rotation to triage ASAP labels Dec 24, 2021
@AbidRahman-MSFT
Copy link

This sounds like a compatibility issue with the next.js framework. @preethikakiru - any idea if we support the next.js framework for Office Add-ins?

@preethikakiru
Copy link
Collaborator

Hello @lkedmi,
Thanks for your question, I'm currently doing some investigation into this and will get back to you soon!
Best,
Preethika

@preethikakiru preethikakiru added the Status: under investigation Issue is being investigated label Jan 12, 2022
@preethikakiru preethikakiru added the Area: DevX Issue is related to Developer Experience (DevX) label Jun 27, 2022
@millerds
Copy link

@preethikakiru this doesn't look like a DevX tooling problem. It looks like an office.js compatibility problem and should go to the office.js engineers.

@millerds millerds removed their assignment Jun 28, 2022
@lkedmi
Copy link
Author

lkedmi commented Jun 29, 2022

I will say that I moved on to a more "classic" solution but it'll be nice if we could use modern meta frameworks to build office add-ins.

@sureshjoshi
Copy link

sureshjoshi commented Jun 30, 2022

@lkedmi Could you please re-name this issue's title to not specify Next.js? Perhaps something like "Office.js should not null out history APIs"

I've had this problem with various React routers, and am currently having this issue with SvelteKit.

This is entirely a problem inside Office.js, which nulls out pushState and replaceState, and breaks modern routing libraries because IE11 does not have the HTML5 History APIs.

office-js/dist/office.debug.js

Lines 1960 to 1964 in 64d4977

var isOutlookAndroid = _hostInfo.hostType == "outlook" && _hostInfo.hostPlatform == "android";
if (!isOutlookAndroid) {
window.history.replaceState = null;
window.history.pushState = null;
}

The OfficeJS documents mention that IE11 is still used in the field, but it does not have first-class support, as referenced here: https://docs.microsoft.com/en-us/office/dev/add-ins/concepts/browsers-used-by-office-web-add-ins and https://docs.microsoft.com/en-us/office/dev/add-ins/develop/support-ie-11

  • Office on the web no longer opens in Internet Explorer. Consequently, AppSource no longer tests add-ins in Office on the web using Internet Explorer as the browser
  • AppSource still tests for combinations of platform and Office desktop versions that use Internet Explorer, however it only issues a warning when the add-in does not support Internet Explorer; the add-in is not rejected by AppSource.
  • The Script Lab tool no longer supports Internet Explorer.

Common workarounds:

Some people use NPM libraries which add history polyfills or support. With some routers, you can use HashRouter support (if they have it). I use variations of this silly workaround: https://stackoverflow.com/a/53662709/992509

<script type="text/javascript">
    window._historyCache = {
        replaceState: window.history.replaceState,
        pushState: window.history.pushState
    };
</script>

<script type="text/javascript" src="https://appsforoffice.microsoft.com/lib/1/hosted/office.js"></script>

<script type="text/javascript">
    window.history.replaceState = window._historyCache.replaceState;
    window.history.pushState = window._historyCache.pushState;
</script>

The Request:

Could someone please remove those 5 lines of code and let modern browsers/routing be the norm, and let the rare failures on unsupported browsers be handled on a case-by-case basis.

IE11 is now retired and no longer supported by Microsoft. AppSource doesn't mandate IE11 support. Most Office variants (other than unsupported operating systems, or non-subscription Office purchases before 2020) can use the HTML5 history API.

Please delete those 5 lines, and add documentation surrounding the error that would appear if you use IE11 and try to use those APIs.

cc: @chiz-ms @xiaoyuMS

References:

This problem has come up a few times, with many workarounds. Here's a non-exhaustive list of the resources I've needed to look at while solving this issue in the past. The first issue is over 3 years old.

@xiaoyuMS
Copy link

xiaoyuMS commented Jul 1, 2022

@AbidRahman-MSFT @preethikakiru Does anybody know who is the contactor of office.js?

@lucasgadams
Copy link

Any update?

@aorsten
Copy link

aorsten commented Mar 13, 2024

We're also using NextJS, and are using the "silly workaround" mentioned by @sureshjoshi above.

Any updates here? Are there any other known NextJS incompatibilities?

@tqmp
Copy link

tqmp commented Mar 21, 2024

@aorsten I am also facing the same problem with nextjs. The workaround seems to not work anymore following the most recent outlook update.

@aorsten
Copy link

aorsten commented Apr 15, 2024

According to this, the problem is supposed to be fixed: #1344 (comment)

Can anyone confirm?

@xiruatms xiruatms added the Needs: author feedback Waiting for author (creator) of Issue to provide more info label Jun 4, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it is marked as needing author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your interest in Office Add-ins!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: no recent activity Issue or PR is stale (no recent activity) label Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: DevX Issue is related to Developer Experience (DevX) Area: Word Issue related to Word add-ins Needs: author feedback Waiting for author (creator) of Issue to provide more info Status: no recent activity Issue or PR is stale (no recent activity) Status: under investigation Issue is being investigated Type: programming question How-to question that should be posted to Microsoft Q&A
Projects
None yet
Development

No branches or pull requests