New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose feature activation fields when decoding transaction #317

Merged
merged 1 commit into from Dec 31, 2015

Conversation

Projects
None yet
2 participants
@dexX7
Copy link
Member

dexX7 commented Dec 30, 2015

Expose feature activation fields when decoding transaction to support parsing of feature activation transactions.

This resolves #314.

@zathras-crypto

This comment has been minimized.

Copy link

zathras-crypto commented Dec 30, 2015

Reviewed & tested, all looks fine:

$ src/omnicore-cli --testnet omni_gettransaction 21c208f6b01274e509f32ccebf74b9c886d1c78c664b7f9121ccc8f805d23c22
{
    "txid" : "21c208f6b01274e509f32ccebf74b9c886d1c78c664b7f9121ccc8f805d23c22",
    "fee" : "0.00003804",
    "sendingaddress" : "mpZATHupfCLqet5N1YL48ByCM1ZBfddbGJ",
    "ismine" : true,
    "version" : 65535,
    "type_int" : 65534,
    "type" : "Feature Activation",
    "featureid" : 1,
    "activationblock" : 530285,
    "minimumversion" : 999,
    "valid" : false,
    "blockhash" : "000000000000060725730562ffdc22e2ba38babbc1bc8336afafc4df1070e345",
    "blocktime" : 1439455392,
    "block" : 530276,
    "confirmations" : 99076
}

OK to merge :)

@dexX7 dexX7 modified the milestone: 0.0.10.1 Dec 30, 2015

@dexX7 dexX7 force-pushed the dexX7:oc-0.10.1-rpc-expose-activation branch to b4c9e89 Dec 30, 2015

@dexX7 dexX7 merged commit b4c9e89 into OmniLayer:omnicore-0.0.10 Dec 31, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

dexX7 added a commit that referenced this pull request Dec 31, 2015

Merge pull request #317
b4c9e89 Expose feature activation fields when decoding transaction (dexX7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment