Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Protect uint256 plain integer math #409
The approach of returning a straight zero when the numerator is zero seems sound.
Confirming discussions on Slack:
OK to merge once this full reparse with
Just as a heads up - this passed the checkpoint for 420,000 just fine.
I'm currently syncing the last 1000 or so blocks until it's up to date so I can compare the hashes for the latest block against 0.0.11-rc2 (before we changed this). I fully expect them to match, it's just another sanity check.
All good on the final test.
I also don't usually use these calls interactively so didn't notice the extra