Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use X.X.X.X version format for Windows product version #452

Merged
merged 1 commit into from
Jan 23, 2017
Merged

Use X.X.X.X version format for Windows product version #452

merged 1 commit into from
Jan 23, 2017

Conversation

dexX7
Copy link
Member

@dexX7 dexX7 commented Jan 22, 2017

Any other format than X.X.X.X for the Windows setup version results in the following error:

Error: invalid VIProductVersion format, should be X.X.X.X
Error - aborting creation process
error: could not build omnicore-0.1.99-win64-setup.exe

This was discovered as part of #437.

@zathras-crypto
Copy link

Thanks dude, OK to merge

@dexX7 dexX7 merged commit c598412 into OmniLayer:develop Jan 23, 2017
dexX7 added a commit that referenced this pull request Jan 23, 2017
@dexX7
Merge #452: Use X.X.X.X version format for Windows product version
50d3356 
c598412 Use X.X.X.X version format for Windows product version (dexX7)
@dexX7 dexX7 mentioned this pull request Jan 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build status: ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dexX7 @zathras-crypto