-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make "dotnet build" work on non-Windows platforms #1449
Conversation
@@ -6,6 +6,8 @@ | |||
<GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles> | |||
</PropertyGroup> | |||
|
|||
<Import Project="../../build/netfx.props" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these be brought in via Directory.build.props
or Directory.build.targets
?
Seems silly to have to add it to all project files if we could avoid it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that but it doesn't get loaded at all then. Seems like <Import Project="..." />
doesn't work via those extensibility points.
…into feature/dotnet-build-unix
I have removed the original quite "hacky" approach and used the new |
This follows a similar solution from the F# compiler dotnet/fsharp#4391
We now import Mono reference assemblies to allow commands like
dotnet build
ordotnet test
to work outside of Windows.This simplifies and helps development as you can quickly build without having to use the build script and it's bootstrapping features.
At the moment trying to run
dotnet build
on non-Windows against omnisharp-roslyn results in a flood of errors like these: