Fix running unit tests defined in nested classes #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-driscoll
approved these changes
Jan 30, 2017
| } | ||
|
|
||
| var builder = s_cachedBuilder.Acquire(); | ||
| try |
There was a problem hiding this comment.
I'm suprised this behavior is not part of the Roslyn Api
There was a problem hiding this comment.
Yeah, Roslyn didn't want to be an API for metadata.
filipw
approved these changes
Jan 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/vscode-csharp#743 and fixes dotnet/vscode-csharp#1151
The issue here is that the metadata name for nested classes was not correct. OmniSharp would report "A.B.C" for the following code, but it should be "A.B+C".