New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix running unit tests defined in nested classes #739
Merged
DustinCampbell
merged 2 commits into
OmniSharp:dev
from
DustinCampbell:fix-unit-tests-in-nested-classes
Jan 30, 2017
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
71 changes: 71 additions & 0 deletions
71
src/OmniSharp.Abstractions/Extensions/ISymbolExtensions.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using Microsoft.CodeAnalysis; | ||
namespace OmniSharp.Extensions | ||
{ | ||
public static class ISymbolExtensions | ||
{ | ||
private readonly static CachedStringBuilder s_cachedBuilder; | ||
|
||
public static string GetMetadataName(this ISymbol symbol) | ||
{ | ||
if (symbol == null) | ||
{ | ||
throw new ArgumentNullException(nameof(symbol)); | ||
} | ||
|
||
var symbols = new Stack<ISymbol>(); | ||
|
||
while (symbol != null) | ||
{ | ||
if (symbol.Kind == SymbolKind.Assembly || | ||
symbol.Kind == SymbolKind.NetModule) | ||
{ | ||
break; | ||
} | ||
|
||
if ((symbol as INamespaceSymbol)?.IsGlobalNamespace == true) | ||
{ | ||
break; | ||
} | ||
|
||
symbols.Push(symbol); | ||
symbol = symbol.ContainingSymbol; | ||
} | ||
|
||
var builder = s_cachedBuilder.Acquire(); | ||
try | ||
{ | ||
ISymbol current = null, previous = null; | ||
|
||
while (symbols.Count > 0) | ||
{ | ||
current = symbols.Pop(); | ||
|
||
if (previous != null) | ||
{ | ||
if (previous.Kind == SymbolKind.NamedType && | ||
current.Kind == SymbolKind.NamedType) | ||
{ | ||
builder.Append('+'); | ||
} | ||
else | ||
{ | ||
builder.Append('.'); | ||
} | ||
} | ||
|
||
builder.Append(current.MetadataName); | ||
|
||
previous = current; | ||
} | ||
|
||
return builder.ToString(); | ||
} | ||
finally | ||
{ | ||
s_cachedBuilder.Release(builder); | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm suprised this behavior is not part of the Roslyn Api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, Roslyn didn't want to be an API for metadata.