Update omnisharp-roslyn

[giggio]

Right now it is outdated. The current version of omnisharp-roslyn on its master branch supports .NET Core project, but the version that omnisharp-vim is referencing does not. Please update it.

[thinca]

Thanks. Is there no problem? If yes, I'll update.
I haven't been able to follow up the latest version of omnisharp-roslyn.
Omnisharp-roslyn has no documentation for developer. This is very hard for a client developer 😥

[giggio]

The only hard thing is that you have to manually compile it. But it works. I already updated my fork, see: https://github.com/giggio/omnisharp-vim/commit/36aa65fa87db6cc4b1f6ccfaedfec3a4a4cb3a3b
I can send a PR.

[giggio]

Just sent PR #267.

[willl]

Just so you know, there's also an omnisharp-roslyn DEV branch which has a lot of active development being pushed into it. As well as an active PR, to merge changes from DEV into MASTER. Or you could just grab a release (either as a binary, or source code)?

@thinca: What sort of documentation are you after? Is it for new features that have been added, or something else? If you have something in mind of what you'd like to see, please mention it so I can pass it on.

[thinca]

@willl Thanks.

I want:

• API reference, which describes all endpoints, and its input and output.
• Command line reference of OmniSharp command.
• About stdio mode.

I understand manpower is not enough.
However, it is difficult for non core member of omnisharp-roslyn to follow the latest version without documentation.

[willl]

@thinca Thank you. I'll start an issue in the omnisharp-roslyn repo with that in an attempt to get the ball rolling.

[willl]

@thinca: I've linked your comment from another existing issue that was also requesting some documentation.

This document contains some documentation on stdio.

And all the current end points are listed here. But yeah, some documentation would be nice. I'm not all that familiar with it myself.

[thinca]

@willl Thank you!! 😆

[giggio]

@willl the version on PR #267 is the one I tested, that is why it is there. I can guarantee it. Is the dev branch stable, meaning: will it always compile and tests pass?
Also, it would be nice if there was an easier way to get it ready to run. Right now it is not clear what the steps are.

[willl]

@giggio The dev branch isn't guaranteed to be stable, no, but is fairly active and has new features added to it quite often. Looking at the commit that you're compiling against, I think most of what's new since then have been related to MS Build/csproj support. As well as fixes to encoding support when using stdin/stdout and also fixes for macOS sierra support.

I'm not too sure when they are planning to next merge things from DEV into MASTER. So if you want to try the new MS Build/csproj support right now (it's basically in preparation for the upcoming move from .xproj/project.json to .csproj/MSBuild as mentioned here).

[giggio]

@willl Ok, tks for the info, I will try it out. But, for the PR, I think it is best we keep it pointed to master.
Also, do you have directions on how to better build omnisharp-roslyn so it works as expected with omnisharp-vim? I tried a lot of things, and something worked. I think it was .\build.ps1 -Install.

I also had to change Vim to use:

let g:OmniSharp_server_path = join([expand('<sfile>:p:h'), 'bundle', 'omnisharp-vim', 'omnisharp-roslyn', 'artifacts', 'scripts', 'Omnisharp'], '/')

[willl]

@giggio: Do the build docs help? https://github.com/OmniSharp/omnisharp-roslyn/blob/dev/BUILD.md

[giggio]

They help, but it is not clear what target I need to use.

[giggio]

Closed on #267.