Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt user to install Blazor WASM companion extension if needed #4392

Merged
merged 2 commits into from
Feb 11, 2021

Conversation

captainsafia
Copy link
Member

Detects if the companion extension is installed if the user is editing a Blazor WASM project and prompts them to install it if not.

The companion extension is a new requirement for debugging Blazor WASM on VS Code to allow for:

  • support for remote debugging
  • faster launching for debugging sessions
  • ability to debug on apps with windows auth configured

Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If this were a behavior you would like the vendors to test as part of release validation, then you could add a section to the test-plan.

Copy link
Contributor

@NTaylorMullen NTaylorMullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the debug experience if the user doesn't have the companion installed?

@captainsafia
Copy link
Member Author

If this were a behavior you would like the vendors to test as part of release validation, then you could add a section to the test-plan.

Updated the test plan.

What's the debug experience if the user doesn't have the companion installed?

The user will be able to run the the app and open it in a standard browser but the debugging browser will not launch.

@JoeRobich JoeRobich merged commit 0938f0f into dotnet:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants