Exhaust error reponse bodies to avoid connection pool stall. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS just realised I am probably not cleaning up the server in the commit, am aware of it (: |
|
Looks sound to me overall. I cannot test it until Friday, but you're welcome to land it. |
|
Thanks very much for peeking at this Andreas, enjoy your break! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Landing this on mine mainly for the purposes of review - I'll land it directly once we've had a chance to discuss it.
I think the fix works by correctly exhausting the body. The test sets the maxSockets really low such that it will only succeed if the sockets were correctly closed and I got the code down to only an additional include of http, although it does start a server up.
AJB