Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bower support #13

Closed
wants to merge 2 commits into from
Closed

Add bower support #13

wants to merge 2 commits into from

Conversation

misterion
Copy link

Subj

@gustavnikolaj
Copy link
Collaborator

I have never used bower, so please correct me if I'm wrong.

I'll be happy to merge this, when we have worked through the comments I posted :-)

@misterion
Copy link
Author

I removed the dependency. Yes, it`s possible to use git url as bower component source but much more comfortable to use it via bower install.

@gustavnikolaj
Copy link
Collaborator

You should have dependencies matching the ones in package.json, otherwise the plugin won't work.

Wouldn't you be able to install from github by running: bower install One-com/knockout-popupTemplate?

@misterion
Copy link
Author

Yes, thanx.

@gustavnikolaj
Copy link
Collaborator

If you reintroduce the (correct) dependencies, and remove the version tag, I'll merge immediately.

@gustavnikolaj
Copy link
Collaborator

@misterion Haven't heard back from you yet, so I'll be closing this PR. Please reopen if it's still relevant to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants