Fix #816 - Fix shortcuts on Android 8.0 Oreo #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update to use support library requestPinShortcut() so shortcuts work pre and post Android 8.0 * Change launcher icons to be specific to shortcut (stop, route, recent, star) * Update PNG resources for higher resolutions required by launcher icons * Refactor a few updated PNG resources for standard naming conventions * Add raw SVGs used to generate PNG icons in /icons folder TODO: * Test all shortcuts! On both Android 8.0 and lower.
barbeau
force-pushed
the
fix-shortcuts
branch
from
8dae819
to
95d8649
Compare
…oid into fix-shortcuts
* Switch from using clock to material design "history" icon for "Recent routes/stops" * Increase padding around ends of icons so "recents" shortcut icon doesn't look as cramped * Remove unused icons
…om launcher widget menu
* Currently they are all cut off, like "OneBusAwa...". Now you can actually see "Route" or "Stop"
* This shouldn't be "CREATE_SHORCUT", because in an Activity like NightLightActivity that functions as both the Activity to create the shortcut when triggered via the launcher menu, as well as the Activity that shortcut opens, it prevents the Activity from opening.
* Also refactor common code for creating route and stop shortcuts into UIUtils
barbeau
changed the title
themonki
added a commit
to themonki/onebusaway-android
that referenced
this pull request
Jan 2, 2018
* Based on commit 3bd995d - Fix OneBusAway#816 - Fix shortcuts on Android 8.0 Oreo (OneBusAway#820) * Based on commit 82feedb - add a contributor * Based on commit fd6ff09 - Fix OneBusAway#404 - Add social functionality via Embedded Social (OneBusAway#744) * Based on commit c6422a3 - Update "What's New" to prepare for release * Based on commit fd48a27 - Update "What's New" to include bug fixes
barbeau
pushed a commit
that referenced
this pull request
Jan 18, 2018
* Update Spanish Translations * Based on commit 3bd995d - Fix #816 - Fix shortcuts on Android 8.0 Oreo (#820) * Based on commit 82feedb - add a contributor * Based on commit fd6ff09 - Fix #404 - Add social functionality via Embedded Social (#744) * Based on commit c6422a3 - Update "What's New" to prepare for release * Based on commit fd48a27 - Update "What's New" to include bug fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't merge yetShortcutCompat.requestPinShortcut()so shortcuts work pre and post Android 8.0/iconsfolderTODO: